On Wed, 27 Feb 2013, Joe Mistachkin wrote:
> 
> Sergei Gavrikov wrote:
> > 
> > Has anyone seen a "broken" output on the side-by-side diff pages for
> > non-English texts? 
> > 
> 
> Do you have an example that is viewable online?

Find, please, a test

  http://chiselapp.com/user/sg/repository/pangrams

Look at side-by-side diff views from 2nd to 3rd check-in and from 3rd to
4th.

For example

  
http://chiselapp.com/user/sg/repository/pangrams/fdiff?v1=edab872a806e8d4c&v2=6936fca46ff9d180

  Left-side hunk: 30
  Right-side hunks: 29, 81, 126, 137

Of course, unified diff has no such quirks.

> > If such an issue exists and it is a limitation the sbs's algorithm,
> > what do you think, Is it good idea to add new Fossil setting to
> > manage the default behavior the sbs for vdiff, fdiff, and
> > time-line's on-click events, i.e.  set sbs=1 or sbs=0 by a
> > request/setting? 
> >
> 
> Personally, I think it might be nice to have such a setting, even if
> the side-by-side diff works perfectly for all cases.

For now, I patch only 4-lines to get sbs=0 by default

 info.c     |    6 +++---
 timeline.c |    2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

But perhaps, I missed other places.

Sergei

> --
> Joe Mistachkin
> 
> _______________________________________________
> fossil-users mailing list
> fossil-users@lists.fossil-scm.org
> http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
> 
_______________________________________________
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users

Reply via email to