Fossil's internal SQLite is currently compiled with the following options (main.mk): SQLITE_OPTIONS = -DSQLITE_OMIT_LOAD_EXTENSION=1 \ -DSQLITE_ENABLE_LOCKING_STYLE=0 \ -DSQLITE_THREADSAFE=0 \ -DSQLITE_DEFAULT_FILE_FORMAT=4 \ -DSQLITE_OMIT_DEPRECATED \ -DSQLITE_ENABLE_EXPLAIN_COMMENTS
But build.wiki recommends: * -DSQLITE_OMIT_LOAD_EXTENSION=1 * -DSQLITE_ENABLE_LOCKING_STYLE=0 * -DSQLITE_THREADSAFE=0 * -DSQLITE_DEFAULT_FILE_FORMAT=4 The options SQLITE_OMIT_DEPRECATED and SQLITE_ENABLE_EXPLAIN_COMMENTS are useful on trunk, making sure that Fossil doesn't use any deprecated SQLite API's and for outputting additional debugging information. But are they useful in a production build as well? (read: "branch-1.28") SQLITE_OMIT_DEPRECATED is quite harmless: Using it makes the build smaller, and Fossil is not supposed to use deprecated SQLite API's anyway. But the following comment in SQLite suggests that SQLITE_ENABLE_EXPLAIN_COMMENTS should not be used in production builds: <http://www.sqlite.org/src/artifact/9f4bfc52672acbb0?ln=819-824> Any opinions? Does the documentation need modification? Of course, any package maintainer can either patch their own main.mk or just use --disable-internal-sqlite, but still..... I think that Fossil should follow it's own recommendations in production builds. Regards, Jan Nijtmans _______________________________________________ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users