On Mon, 17 Mar 2014 09:32:49 +0100, Martijn Coppoolse <li...@martijn.coppoolse.com> wrote:

On 15-3-2014 17:08, j. van den hoff wrote:
Does not work for me. Clicking "Edit" in the ticket shows the "Edit
Ticket" page where edit every ticket field (title, status, etc.) and
also append a new comment/remark, but there seems to be no user
interface for editing previous comments even if I submitted the ticket
and I am the repo admin. This was possible some time ago IIRC.

yes, same for me here: no way to edit previous comments, irrespective of
privileges.

This was changed when the `ticketchng` table was added.

That table enables tracking all comments added to a ticket separately. Before, a ticket only had a single 'comments' field, and each new comment was appended to that field. Editing the comments was therefore easy; just a question of replacing the entire field, instead of appending to it.

Now, it's become much more complex, because you'd need to replace a specific row in the ticketchng table. In itself, this wouldn't be that hard to do, but I've no idea how to process such an edit as a ticket-change artifact, which is what ultimately determines what ends up in the ticket and ticketchng tables.

My guess is that the current default ticket-edit page doesn't allow editing separate comments either because it's impossible in this setup, or because it was too hard to do.

(I've tried adjusting the ticket-edit page to allow this, because I wanted to restore the change preview possibility I had built in the old ticket-edit page, but gave up because it was taking too much time to solve).

thank you for clarifying the situation a bit. I would hope that making this (retrospective modification/correction of ticket comments) is not really impossible in the current setup and that one of the core developers would look into this if his time permits: it is really a nuisance to look at a seriously misleading/erroneous/misplaced ticket comment (the more so, if it happens not to be the very last one) and not being able to correct it. "append only" really is not optimal. I do not of course understand sufficiently why the present setup was chosen but superficially I would be more happy with a logic similar to the wiki pages: just allow editing of a single comment field and track all edits in the timeline (I understand from your mail that this was the previous setup here, right?).

could someone in the know comment on this?


--
Using Opera's revolutionary email client: http://www.opera.com/mail/
_______________________________________________
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users

Reply via email to