Candidate fix checked into trunk.
On Tue, May 27, 2014 at 4:21 PM, Richard Hipp <[email protected]> wrote: > Or, maybe $current_page should be HTTP-encoded instead of plaintext. > > > On Tue, May 27, 2014 at 4:19 PM, Andy Bradford > <[email protected]>wrote: > >> Thus said Richard Hipp on Tue, 27 May 2014 15:46:30 -0400: >> >> > I think that's an HTTP thing. In a URL, spaces are encoded as "+". So >> > fossil is doing the right thing in converting "+" characters in the >> > URL into spaces. >> >> It certainly handles them correctly when given them, however, there may >> be a potential buglet in how it publishes the base URL. All of the skins >> for the header include the following: >> >> <base href="$baseurl/$current_page" /> >> >> Which results in the following output: >> >> $ printf 'GET /doc/tip/file%%2b%%2b.wiki HTTP/1.1\r\nHost: >> localhost:8080\r\n\r\n' | nc localhost 8080 | grep base >> <base href="http://localhost:8080/doc/tip/file++.wiki"; /> >> >> So it appears that it doesn't preserve the encoding. Should it? >> >> Perhaps this should really be something like the following? >> >> <th1> >> html "<base href='$baseurl/[httpize $current_page]' />" >> </th1> >> >> This results in the following output: >> >> $ printf 'GET /doc/tip/file%%2b%%2b.wiki HTTP/1.1\r\nHost: >> localhost:8080\r\n\r\n' | nc localhost 8080 | grep base >> <base href='http://localhost:8080/doc%2Ftip%2Ffile%2B%2B.wiki' /> >> >> Thanks, >> >> Andy >> -- >> TAI64 timestamp: 400000005384f35f >> > > > > -- > D. Richard Hipp > [email protected] > -- D. Richard Hipp [email protected]
_______________________________________________ fossil-users mailing list [email protected] http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
