I see.  That’s great news!

However, the current implementation in branch cmdline-timeline-enhancement does 
not seem to behave this way.  It make give priority to keywords over tags but 
not over filenames.  For example,

C:\temp\xxx>f tim now
+++ no more data (0) +++

where an slightly older trunk version ([ee46563cbd]) shows several entries 
because it interprets now as datetime.

The experimental version interprets “now” filename, which is not found in this 
case.   But, if I add a dummy file named now in the root directory, then I get:

C:\temp\xxx>f tim now
=== 2014-10-18 ===
20:01:55 [3450ec3047] *CURRENT* Added now filename (user: tonyp tags: trunk)
+++ no more data (1) +++

Thanks.

From: Richard Hipp 
Sent: Saturday, October 18, 2014 10:09 PM
To: Fossil SCM user's discussion 
Subject: Re: [fossil-users] New TIMELINE with 
FILENAMEoption(WAS:FINFOsuggestion)



On Sat, Oct 18, 2014 at 2:21 PM, <to...@acm.org> wrote:

  I don’t know if anyone has noticed already, but there is an inherent 
ambiguity between possible dirnames/filenames, and tag names or internal 
keywords, such as current & now used by the timeline command.  If there is a 
filename by the same name does the word refer to the filename, or to the 
keyword or tag?  In some cases, it can be disambiguated by checking for extra 
required parameters (e.g., BEFORE requires something more to follow).

  Now, before you get overly alarmed by this, let me point out that, 
apparently, the same ambiguity already existed between tags and keywords.  If, 
say, the tag “now” existed, should “fossil tim now” refer to the time now or to 
the tag named “now”?  (From a quick test, it seems to treat it as the keyword.)

It's the keyword.  If you have a subdirectory or file named "now" then get a 
timeline for it using


    fossil timeline ./now

In other words, add "./" to the front.


 

  I don’t know what the most reasonable solution might be, other than to ignore 
the problem altogether.  Some suggestions:

  Require a filename to be prefixed by some special character like @
  For example, “fossil tim @now” would refer to file or directory “now” and not 
the time now.  It would be better that the special character be applied to the 
keywords and not the filenames but it may be too late for that if compatibility 
with previous behavior must be maintained.

  Another possible solution I see would be to add the new functionality under a 
new command, which would actually use the same timeline code but without 
honoring any of the
  ?WHEN? ?BASELINE|DATETIME?
  part.  For example, it could be called “history” or “fileline” or “trace” or 
whatever.  It would use the same timeline code but without acknowledging any of 
the timeline options.

  Finally, the help screen needs updating to reflect the new changes.

  From: to...@acm.org 
  Sent: Saturday, October 18, 2014 8:00 PM
  To: Fossil SCM user's discussion 
  Subject: Re: [fossil-users] New TIMELINE with FILENAME 
option(WAS:FINFOsuggestion)

  I re-ran all use cases I had tried before, and everything seems OK.

  * Case-insensitivity for Windows (OK)
  * Root directory (OK)
  * No duplicates (OK)

  From: Richard Hipp 
  Sent: Saturday, October 18, 2014 1:36 PM
  To: Fossil SCM user's discussion 
  Subject: Re: [fossil-users] New TIMELINE with FILENAME option 
(WAS:FINFOsuggestion)



  On Sat, Oct 18, 2014 at 5:37 AM, <to...@acm.org> wrote:

    Case sensitivity does not work for directory names, only for filenames.


  Please try again with the latest.


  Are we ready to merge this enhancement into trunk?  Are there any objections 
to the new command-line timeline capability? 



  -- 
  D. Richard Hipp
  d...@sqlite.org 

------------------------------------------------------------------------------
  _______________________________________________
  fossil-users mailing list
  fossil-users@lists.fossil-scm.org
  http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


------------------------------------------------------------------------------
  _______________________________________________
  fossil-users mailing list
  fossil-users@lists.fossil-scm.org
  http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


  _______________________________________________
  fossil-users mailing list
  fossil-users@lists.fossil-scm.org
  http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users





-- 
D. Richard Hipp
d...@sqlite.org 


--------------------------------------------------------------------------------
_______________________________________________
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
_______________________________________________
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users

Reply via email to