On Aug 17, 2016, at 12:33 PM, Kain Abel <[email protected]> wrote:
> 
> Hi Warren,
> 
> 2016-08-17 17:43 GMT+02:00 Warren Young <[email protected]>:
>> On Aug 16, 2016, at 6:45 AM, Kain Abel <[email protected]> wrote:
>>> Oh, that surprises me now. This implicit behavior is not explicit
>>> documented. There is no warning that all stashed changes will be also
>>> dropped when repository will be closed. Neither in 'stash --help' nor
>>> in 'close --help’.
>> 
>>    $ f close
>>    closing the checkout will delete your stash
> 
> Uh, reading is also not my forte and I wasted your time. :(

I wouldn’t say that.  It would indeed be nice if Fossil told you up front, as 
you said.  I was just pointing out that it warns you before deleting the stash, 
and requires that you give --force to close it anyway, or that you manually 
empty the stash first.

The documentation for --force doesn’t explain this second usage, either.  It 
only talks about “uncommitted changes,” which is not quite the same thing as 
stashed changes, at least to my mind.  “Uncommitted” implies that committing 
them is the intent, whereas stashed changes may never be committed; if I was 
certain about keeping these changes or throwing them away, they wouldn’t be in 
the stash, they’d be committed or reverted.

So, maybe you want to prepare a documentation patch rather than a functionality 
patch.
_______________________________________________
fossil-users mailing list
[email protected]
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users

Reply via email to