On 09/23/17 14:40, Richard Hipp wrote:
On 9/23/17, Andy Goth <andrew.m.g...@gmail.com> wrote:
I tried this, only to find that annotate only works when given a
manifest in which a file actually changed. Otherwise I get this
error:
file #631 is unchanged in manifest #37365
Proposed changes:
(1) Move the fix for the error above inside of the annotate_file()
routine. In other words, have annotate_file() automatically seek out
the checkin containing the most recent change to the file.
(2) Move the call to compute_direct_ancestors() inside of annotate_file().
Agree to both. Would you like me to take a crack at this? I don't want
to duplicate your effort.
(3) Add a new parameter to annotate_file() which is the "destination"
of the search. If "destination" is 0, then it does an ordinary
annotation for all direct ancestors of "mid". But if "destination" is
non-zero then it does an annotation of changes along the shortest
[path] from "mid" to "destination".
Speaking of path, I noticed an issue with the "Path" command link on the
diff page. (Well, I should say that first I noticed the *existence* of
the "Path" command link, since I never knew it was there before.)
http://fossil-scm.org/index.html/timeline?me=c550402982cc9755&you=4c17ab60b9665e56
Here, the path goes backwards from "me" to its branch root then to "you".
http://fossil-scm.org/index.html/timeline?me=7f29e2640ab5d1dc&you=4c17ab60b9665e56
Yet here, the path goes forwards from "me" to the tip of the branch,
then to where that tip is integrated, then to "you".
What's the difference between the two cases?
Is this the same path logic that would be employed by annotate_file()
when given a destination?
(4) Given the changes above, it should be relatively simple to add
switches to the "annotate" command, and new query parameters to the
/annotate webpage, to do a reverse annotation.
Sounds delightful! I hope this works.
--
Andy Goth | <andrew.m.goth/at/gmail/dot/com>
_______________________________________________
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
