Hi Mark, Thanks for sending this out - it looks good! I have 2 comments/suggestions: 1) Under your assumptions, you may want to add "the agent will assume the email address given is correct".
2) Adding a column to the user table for the email agent to timestamp when the notification was sent doesn't feel right. A) It will only record the most recent email sent - what if the user submits multiple jobs and wants email notifications for each? Although, the user will receive multiple email notifications, only the most recent one will be recorded in the DB. B) Adding an email timestamp column in the user table doesn't seem like the right place to store this info. Maybe the email agent should maintain it's own table with info like, user, job id, timestamp, etc... My 2 cents. M > -----Original Message----- > From: Donohoe, Mark > Sent: Monday, February 02, 2009 11:23 AM > To: oslo.tools-team > Subject: email notification design review > > Folks, > > This is mostly for Bob and Chan, but anyone is welcome to > read it and provide feedback. > > The first draft of the email notification design is ready for > review. > Please review and provide feedback. You can find it at: > > http://fossology.org/email-design > > Thanks for your time and comments. > > -- > Mark Donohoe > ALPS/OSTT, Cupertino CA. > fossology.org > > _______________________________________________ fossology mailing list [email protected] http://fossology.org/mailman/listinfo/fossology
