Mark, You also need to modify the job table. Remove the field job_email_notify and add a new table with the notification timestamps.
Bob On Feb 2, 2009, at 1:49 PM, Benson, Channing D wrote: > In general, the proposal looks good. > > Presuming that I followed it correctly... > > I concur with Mary that you probably want to keep more than just the > last email sent; some kind of history would be nice. This could help > solve the issue of flagging mail messages that don't reach their > destination. > > Some sort of automated housekeeping UI might be nice too in this case. > > I like Bob's suggestion of being able to subscribe to changes, like > a new upload. > > -- Chan > > > Channing Benson > Open Source / Linux R&D > Hewlett-Packard Company > (484) 472-8603 > > -----Original Message----- > From: [email protected] [mailto:[email protected] > ] On Behalf Of Ruscio, Michael > Sent: Monday, February 02, 2009 3:20 PM > To: Laser, Mary; Donohoe, Mark > Cc: [email protected] > Subject: Re: [FOSSology] email notification design review > > Maybe have a separate page the user can access within the UI to keep > track of the email-related stuff....?? > > -----Original Message----- > From: [email protected] [mailto:[email protected] > ] On Behalf Of Laser, Mary > Sent: Monday, February 02, 2009 3:09 PM > To: Donohoe, Mark > Cc: [email protected] > Subject: Re: [FOSSology] email notification design review > > Hi Mark, > Thanks for sending this out - it looks good! I have 2 comments/ > suggestions: > > 1) Under your assumptions, you may want to add "the agent will > assume the email address given is correct". > > 2) Adding a column to the user table for the email agent to > timestamp when the notification was sent doesn't feel right. > A) It will only record the most recent email sent - what if the user > submits multiple jobs and wants email notifications for each? > Although, the user will receive multiple email notifications, only > the most recent one will be recorded in the DB. > B) Adding an email timestamp column in the user table doesn't seem > like the right place to store this info. Maybe the email agent > should maintain it's own table with info like, user, job id, > timestamp, etc... > > My 2 cents. > M > >> -----Original Message----- >> From: Donohoe, Mark >> Sent: Monday, February 02, 2009 11:23 AM >> To: oslo.tools-team >> Subject: email notification design review >> >> Folks, >> >> This is mostly for Bob and Chan, but anyone is welcome to read it and >> provide feedback. >> >> The first draft of the email notification design is ready for review. >> Please review and provide feedback. You can find it at: >> >> http://fossology.org/email-design >> >> Thanks for your time and comments. >> >> -- >> Mark Donohoe >> ALPS/OSTT, Cupertino CA. >> fossology.org >> >> > _______________________________________________ > fossology mailing list > [email protected] > http://fossology.org/mailman/listinfo/fossology > _______________________________________________ > fossology mailing list > [email protected] > http://fossology.org/mailman/listinfo/fossology > > _______________________________________________ > fossology mailing list > [email protected] > http://fossology.org/mailman/listinfo/fossology _______________________________________________ fossology mailing list [email protected] http://fossology.org/mailman/listinfo/fossology
