Ok, thanks. Just thought I should mention it. > -----Original Message----- > From: Anthony Jenkins [mailto:[email protected]] > Sent: Friday, June 26, 2015 7:46 AM > To: Moore, Robert; Ian Smith; Warner Losh > Cc: [email protected] > Subject: Re: [PATCH] ACPI CMOS region support rev. 6 > > On 06/25/2015 10:33 PM, Moore, Robert wrote: > > How do you handle the fact that there are three different CMOS/RTC > devices defined in the ACPI specification? (There are three different > _HIDs). > Right, each of the three CMOS/RTC devices in the ACPI spec has a different > ACPI ID (PNP0B00, PNP0B01, PNP0B02). FreeBSD's CMOS RTC driver only > attaches to PNP0B00; if a different CMOS device is present, there will be > no CMOS/RTC driver (since we don't know how to talk to it). Should be a > no-op, like for any unsupported device. > > If I had the specs for each of those devices, I could probably cobble > together support for the other two, but that wasn't my original mission... > > Anthony > > > > >> -----Original Message----- > >> From: [email protected] [mailto:owner-freebsd- > >> [email protected]] On Behalf Of Anthony Jenkins > >> Sent: Thursday, June 25, 2015 6:16 PM > >> To: Ian Smith; Warner Losh > >> Cc: [email protected] > >> Subject: Re: [PATCH] ACPI CMOS region support rev. 6 > >> > >> ...and of course I forget the attachment... > >> > >> On 06/25/15 21:14, Anthony Jenkins wrote: > >>> Sooo here's the new and improved rev. 6, "new and improved" because > >>> it increases the diff line count by 332%. > >>>> [ajenkins@ajenkins-hplaptop /usr/src]$ wc -l atrtc_c_rev5.diff > >>>> atrtc_rev6.diff > >>>> 220 atrtc_c_rev5.diff > >>>> 731 atrtc_rev6.diff > >>> This is to satisfy the request to split the atrtc.c driver into a > "core" > >>> part and "bus" parts: > >>>> Looking at patch 5: > >>>> > >>>> You need to rework this so there's an atrtc_acpi.c. Put all the > >>>> ACPI > >> attachment in there. You should also split off the little bit that's > >> ISA- specific into atrtc_isa. Once you do that, we can talk. > >>>> Warner > >>> I actually finished this patch a couple months ago and have been > >>> running it on my laptop, I just don't see the point...maybe Warner > >>> could elaborate on the rationale for his request? At the very > >>> least, this should be two commits - the functional change and the > >>> refactorization request. > >>> > >>> I may have also added Ian's request for verbosity tweaks, but it's > >>> been a while... I don't see any CMOS logging noise FWIW. > >>> > >>> Thanks, > >>> Anthony > >>> > >>> > > _______________________________________________ > > [email protected] mailing list > > http://lists.freebsd.org/mailman/listinfo/freebsd-acpi > > To unsubscribe, send any mail to "[email protected]"
_______________________________________________ [email protected] mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-acpi To unsubscribe, send any mail to "[email protected]"
