On Wednesday, December 18, 2013 2:43:28 pm Adrian Chadd wrote:
> [snip]
> So the standard trop of UNLOCK/WORK/RELOCK is pretty dangerous.
> There's no state re-validation going on when you re-acquire that lock.
> So, although it meets the lock requirements, it may not be 'correct'.
> It's scattered throughout the code base (wifi drivers aren't an
> exception here either, sigh.)
> Just something to keep in mind when you validate the 'correctness' of
> this kind of lock hack.

Agreed.  It needs fixing, but the fix needs to be correct.

John Baldwin
freebsd-current@freebsd.org mailing list
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Reply via email to