On Thu, 12 Jul 2001 01:44:44 -0500,
  Alfred Perlstein <[EMAIL PROTECTED]> said:

Alfred> * Alfred Perlstein <[EMAIL PROTECTED]> [010712 01:42] wrote:
>> * Seigo Tanimura <[EMAIL PROTECTED]> [010711 19:08] wrote:
>> > 
>> > The patch and the results of build test are now on the web page.
>> > 
>> > The discussion of ktrace(2) problem does not cover the solution of
>> > BSD/OS, so it needs updating.
>> 
>> I'm just reviewing the file stuff, I have a number of updates mainly
>> in the areas of needing FFIND_HOLD/fdrop rather than just a simple
>> FFIND.
>> 
>> getvnode(p->p_fd, args->fd, &fp);
>> 
>> I'm quite sure should implicitly do a FHOLD operation on the returned
>> struct file, i don't see this, at least not in linux_getdents()
>> (compat/linux/linux_file.c).

Alfred> Or at least an fhold needs to be done before relasing the lock
Alfred> on the struct file.

Some functions modify a file descriptor, while others do not. At that
point, what we need is a pair of FFIND and FFIND_LOCK. Both of them
hold a file descriptor. FFIND_LOCK locks a file descriptor, while
FFIND does not.

-- 
Seigo Tanimura <[EMAIL PROTECTED]> <[EMAIL PROTECTED]>

To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message

Reply via email to