On Fri, Mar 29, 2002 at 11:44:06AM +0100, Alexander Leidinger wrote:
> > My patches to src/share/mk/ are here:
> >
> > ftp://ftp.jurai.net/users/winter/icc.mk.diff
> >
> > This allows you to set 'USE_ICC' and 'ICFLAGS' and build stuff.
This is fine just to get things working. But please consider Doing It
Right -- that being wrap the definitions of CC, CFLAGS, and PICFLAG with
USE_ICC rather than strew USE_ICC all over the place. For instance:
/usr/share/mk/sys.mk
.if defined(USE_ICC)
CC= icc
.else
CC= cc
.endif
> > -D__ICC__=1
>
> ICC already defines '__ICC', doe we really need this?
I see no reason for it. We should use the vendor's spelling for
identifying their compiler.
> > -D__attribute__(x)=
> > -D__GNUC__=2
>
> Ok as a short term solution, but IMHO this should get solved in the
> source.
Totally agreed for defining __GNUC__.
--
-- David ([EMAIL PROTECTED])
To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message
