On 29 M�r, David O'Brien wrote:
>> > My patches to src/share/mk/ are here:
>> >
>> > ftp://ftp.jurai.net/users/winter/icc.mk.diff
>> >
>> > This allows you to set 'USE_ICC' and 'ICFLAGS' and build stuff.
>
> This is fine just to get things working. But please consider Doing It
> Right -- that being wrap the definitions of CC, CFLAGS, and PICFLAG with
> USE_ICC rather than strew USE_ICC all over the place. For instance:
>
> /usr/share/mk/sys.mk
> .if defined(USE_ICC)
> CC= icc
> .else
> CC= cc
> .endif
- How do you want to solve the single suffix rules then?
- Do we use ${LD} in every significant place?
- What about ports with "CC=${CC}" in CONFIGURE_ENV (they would break
in the USE_ICC case)?
>> > -D__ICC__=1
>>
>> ICC already defines '__ICC', doe we really need this?
>
> I see no reason for it. We should use the vendor's spelling for
> identifying their compiler.
>
>> > -D__attribute__(x)=
>> > -D__GNUC__=2
>>
>> Ok as a short term solution, but IMHO this should get solved in the
>> source.
>
> Totally agreed for defining __GNUC__.
And the __attribute__ line is the reason why libc doesn't work.
Bye,
Alexander.
--
The computer revolution is over. The computers won.
http://www.Leidinger.net Alexander @ Leidinger.net
GPG fingerprint = C518 BC70 E67F 143F BE91 3365 79E2 9C60 B006 3FE7
To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message
