> Mark Murray wrote:
> >>These seem to be the same program.  I'll take this if there are no
> >>objections. 
> > 
> > You have it!
> Okay, here's my vidfont/kbdmap rewrite for review.  Any feedback
> is welcome, the same goes for bug reports :-)

Cool, thank you very much!

Some comments:

o Please put a copyright on the top of this. By preference, please use

o The code style is generally good, but please don't put braces around
  single lines of code, ie use
  for (;;)
  rather than
  for (;;) {

o Please put all the macro strings like default font and directories into
  macros and #include those from (say) vidfont.h.

o Please shorten any long line or comment to less than 80 columns

o Please do not use mktemp(); use mkstemp() instead.

o Please make this WARNS=6 clean as far as is possible.


o       Mark Murray
O.\_    Warning: this .sig is umop ap!sdn

To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message

Reply via email to