On Thu, 11 Mar 2010 20:24:57 -0800
Garrett Cooper <yanef...@gmail.com> wrote:

>     I can haz PR review then? Here's an easy one :)...
> 
> http://www.freebsd.org/cgi/query-pr.cgi?pr=144644
> 

Looks OK to me except I don't like the
        if (something) {
                one-line-of-code();
        }
constructs, but according to style(9) these are sort-of OK, viz

     Closing and opening braces go on the same line as the else.  Braces that
     are not necessary may be left out.
                       ^^^^^^^^^^^^^^^
             if (test)
                     stmt;
             else if (bar) {
                     stmt;
                     stmt;
             } else
                     stmt;

Saved by the "may."

---
Gary Jennejohn (gj@)
_______________________________________________
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Reply via email to