On Thu, Jan 20, 2011 at 12:31:03PM +0800, Adrian Chadd wrote: > On 19 January 2011 18:54, Alexandr Rybalko <[email protected]> wrote: > > Hi, > > > > I`m happy to introduce GEOM_ULZMA module and utilitie to create an ulzma > > image. > > > > Think now it in acceptable for testing/reviewing/committing state. > > > > Wait for your questions. :) > > I like it. I'd like to see the ulzma and gz stuff unified in a later > pass of this code but personally I'm happy to have it committed as-is > so it immediately gets some wider exposure.
IMHO it should first be unified, really. Once it is committed the chances are much lower that it will be unified. Alexandr, would you like to implement some more general geom_compress class or something like that where it is easier to add new algorithms? You can look at geom_label, which is more or less implemented that way. -- Pawel Jakub Dawidek http://www.wheelsystems.com [email protected] http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am!
pgpa7uPdDSjuO.pgp
Description: PGP signature
