On Thursday 13 January 2011 13:42:30 Nikos Vassiliadis wrote: > Hi, > > Please, review the attached patch. It is against yesterday's HEAD > and it virtualizes if_bridge. > > You can use the bridgetest script to create quickly a topology > with redundant links to test STP.
Looks good to me, though I'm wondering is there any particular reason why you prefer to create bridge instances in the "root" vnet first, and then move them to other vnets, instead of creating bridge instances directly in target vnets? In other words: ifconfig bridge1 create ifconfig bridge1 vnet x vs jexec x ifconfig bridge1 create In a near future, each vnet will have its own list of cloning ifnets (currently only lo and vlan cloners are per-vnet, while other cloning ifnet types use global cloners), so maybe it might be a good practice to attempt to avoid having ifnet with its cloner attached in one vnet while being loaned to another (though in some cases this is unavoidable, such as with epair ifnets). Cheers, Marko _______________________________________________ freebsd-virtualization@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-virtualization To unsubscribe, send any mail to "freebsd-virtualization-unsubscr...@freebsd.org"
