Follow-up Comment #5, bug #13621 (project freeciv):

The attached version has some minor style and
formatting improvements and is more or less
good enough to commit, I think. There is though
the obvious problem that ruleset_set_cmd() does
not handle setting side-effects like the
set_command() function does. Really what should
be done is to factor out the changing of the
setting's value into a separate function that
is called by both of them. So set_command()
would parse its command line and call the
function, and ruleset_set_cmd() would parse the
[game] section of the section file and call the
function. Thus the special side-effects would
be handled in just one place by design. But this
can be left for another patch (this patch adds
the appropriate FIXMEs as future reminders).


(file #5931)

Additional Item Attachment:

File name: version4-13621-set.patch.diff  Size:7 KB


Reply to this item at:


  Message sent via/by Gna!

Freeciv-dev mailing list

Reply via email to