Follow-up Comment #12, bug #14037 (project freeciv):

Having an argument with myself...

> transfer_unit() should:
> - If unit can still exist in the tile, or is in transport, it is
> not moved 

We are talking about unit transfers as part of city transfer. City will
remain, but under new owner. can_exist_at_tile() is not correct check at all.
We should check if new owner is allied to us, not if terrain is suitable.

Note also that unit passed to transfer_unit() is not necessarily inside the
homecity being transferred so they need no bouncing at all.

Not teleporting units from transferred city to far away cities but next to
transferred city causes them to be inside borders of new owner. What problems
this will cause?

Anyway, untested patch attached.

(file #6731)
    _______________________________________________________

Additional Item Attachment:

File name: CityTransfNoUnitTeleport_14037.diff Size:3 KB


    _______________________________________________________

Reply to this item at:

  <http://gna.org/bugs/?14037>

_______________________________________________
  Message sent via/by Gna!
  http://gna.org/


_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Reply via email to