URL:
<http://gna.org/bugs/?17937>
Summary: "Sell Obsolete" button in Economy report can never
be used?
Project: Freeciv
Submitted by: jtn
Submitted on: Wed Mar 23 21:58:02 2011
Category: client
Severity: 3 - Normal
Priority: 5 - Normal
Status: None
Assigned to: None
Originator Email:
Open/Closed: Open
Release: 2.2.5,2.3.0-beta3
Discussion Lock: Any
Operating System: Any
Planned Release: 2.3.0,2.4.0
_______________________________________________________
Details:
The Economy (gold) report in various clients has a "Sell Obsolete" button,
which, if you were ever to press it, would sell all buildings of a given type
which are redundant (in the sense clarified by bug #17731), for instance Power
Plants in cities with Hydro Plants (sell_all_improvements(_, TRUE, _, _)).
Unfortunately, in the clients, sensitivity of this button is gated on
improvement_obsolete(), which is different -- it has the narrower meaning of a
building obsoleted by a tech (e.g., Barracks after Gunpowder).
Since obsolete buildings are always automatically sold as soon as they become
obsolete, I don't think this "Sell Obsolete" button can ever become
sensitive.
I think the button should be renamed to "Sell Redundant" (to avoid confusion
with the technical meaning of "Obsolete"). It should probably be sensitive for
buildings where at least one is redundant, and bring up a confirmation saying
exactly how many it's going to sell. (Also the "obsolete" checkbox in the Gtk
Economy report should be renamed "redundant", and probably show Gtk's
"indeterminate" state for buildings some of which are not redundant.)
_______________________________________________________
Reply to this item at:
<http://gna.org/bugs/?17937>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
