Follow-up Comment #8, patch #3346 (project freeciv):

+      if (game.info.turn > game.server.end_turn)
+       /* endturn was reached - rank users based on team scores */
+       rank_users(TRUE);
+      else 
+       /* game ended for victory conditions - rank users based on survival */
+       rank_users(FALSE);
+    } else if ((check_for_game_over() && game.info.turn >
game.server.end_turn)
+              || S_S_OVER == server_state()) {
+      /* game terminated by /endgame command - calculate team scores */
+      rank_users(TRUE);


CodingStyle: Even single lines after if require block:
if () {
...
} else {
...
}


It's not new with behavior with this patch, but I wonder if dead players
should be losers in all cases. Now they are marked as losers in first pass,
but later passes have no aliveness check before the turn players to winners.

    _______________________________________________________

Reply to this item at:

  <http://gna.org/patch/?3346>

_______________________________________________
  Message sent via/by Gna!
  http://gna.org/


_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Reply via email to