Follow-up Comment #3, patch #3620 (project freeciv):

- So it mpodifies actual city state, for example by calling
set_city_production(), instead of just calculating the best solution. I don't
see it restoring city to the original state, so city can end in a weird state
if caller decides not to apply the result.

- Not new with the patch, but it seems that production[] is never initialized,
but assumed to be zero-filled in the beginning

- Minor Style issues: "}else{" -> "} else {", "return(value);" -> "return
value;", empty line between variable declarations and code.

    _______________________________________________________

Reply to this item at:

  <http://gna.org/patch/?3620>

_______________________________________________
  Message sent via/by Gna!
  http://gna.org/


_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Reply via email to