Summary: Move requirement range/survives sanity checking from
req_from_str() to rssanity.c
Submitted by: jtn
Submitted on: Sat Jan 4 19:24:19 2014
Priority: 5 - Normal
Assigned to: None
Discussion Lock: Any
Planned Release: 2.6.0
Currently, req_from_str() does some sanity checking of requirements when
parsing them: it checks validity of ranges for requirements, and (after patch
#4396) the 'survives' field.
cazfi notes in bug #21418 comment 1:
> On a general note, we need to be moving all possible sanity
> checks to sanity_check_ruleset_data() which freeciv-ruledit then
> can use to check ruleset being modified.
req_from_str() should be reduced to checking the syntax of individual fields,
and semantic checking of ranges vs types etc moved to rssanity.c (probably
building on bug #21418).
(I think this will lose us reporting of which filename/section is at fault,
but it can't be helped.)
Reply to this item at:
Message sent via/by Gna!
Freeciv-dev mailing list