Summary: is_req_active can spuriously return FALSE for
RPT_POSSIBLE with continent/city-ranged improvement requirements
Submitted by: jtn
Submitted on: Sat Jan 11 20:17:08 2014
Severity: 3 - Normal
Priority: 5 - Normal
Status: In Progress
Assigned to: jtn
Discussion Lock: Any
Operating System: Any
If there's a requirement for an improvement on the same continent or in the
same city, is_req_active() called with RPT_POSSIBLE and no target city can
return FALSE when it should return TRUE.
I don't know if this is breaking anything important in practice, just noticed
it in passing.
Propose to fix by moving tristate logic inside buildings_in_range(), and
completing its half-finished transition from returning a count to a
boolean-ish (no-one uses it in the former sense any more, at least on trunk,
and some code paths return TRUE/FALSE already).
Reply to this item at:
Message sent via/by Gna!
Freeciv-dev mailing list