Update of patch #4988 (project freeciv):

                  Status:          Ready For Test => None                   
             Assigned to:                  persia => None                   
         Planned Release:                   2.6.0 =>                        


Follow-up Comment #6:

Using RPT_AI just breaks semantics again when patch #4885 is applied (because
improvement_has_effects() can be called outside an AI context), and moreso for
work on patch #4987 (wherein a lightly modified improvement_has_effects() will
be called from the client, presumably by humans).

I suppose I could add RPT_CAPABILITY or similar, and move the unit type flag
hack also to there, so that RPT_CERTAIN blocks requirements being met for that
again, but I think this is just more layers masking the fundamental issues
(and complicating later resolution).  For now, I'll leave this with the prior
less-extreme hack: anyone else should feel free to grab this before I get back
to it.

If someone is going for a smaller solution than the complete rewrite, removing
the erroneous source comments and half-implemented kludges for
is_unittype_in_range(),  is_unitclass_in_range(), and
is_unitclassflag_in_range() is probably a good idea.


Reply to this item at:


  Message sent via/by Gna!

Freeciv-dev mailing list

Reply via email to