Follow-up Comment #10, patch #5306 (project freeciv): You are making progress.
The variable names in do_expel_unit are confusing. I suggest using the words actor (for the unit doing the expulsion) and expelled (or target) in the variable names to make it clear who is who. The even types E_MY_DIPLOMAT_BRIBE and E_ENEMY_DIPLOMAT_BRIBE in the notifications about expulsion are wrong. Use existing events or create new once if no one fits. Why never expel a unit to its capital? The Xaw client needs the button added in the data too. ( See http://repo.or.cz/w/freeciv.git/commitdiff/25ee5735a91265bac09df12eb42dff2ca7037643 ) Update the documentation that foreign isn't hard coded. _______________________________________________________ Reply to this item at: <http://gna.org/patch/?5306> _______________________________________________ Message sent via/by Gna! http://gna.org/ _______________________________________________ Freeciv-dev mailing list [email protected] https://mail.gna.org/listinfo/freeciv-dev
