Follow-up Comment #12, patch #5306 (project freeciv): There is a comment about gold in the new hard coded restriction.
The events: * Expel isn't a spy action. It could be used to teleport domestic units. Change name and group. * Define the tags for icons and sound. The client refused to start because the tileset didn't have the wanted tags. See how http://repo.or.cz/w/freeciv.git/commitdiff/9c7b6d4f6e8f40de2ac51da7be3e1ea7aceb2aec changes data/misc/events.spec and data/stdsounds.soundspec _Well... It's not very "logic". Anyway it's done, but check please._ You aren't alone in not having Xaw client changes as your favorite hobby. The new button is placed wrong. See the pattern of the other buttons. Copy the position fields from button21, increase numbers by 2. Documentation: * Don't mention foreign at all. * Document the restriction (not self) you added. * Explain what expel does (where does it end up?) I recommend sending the expelled unit to the same city a Spy would flee to after completing its mission. Don't worry about sending it to the capital. Some of your code already does this. The parameters of do_expel_unit aren't aligned with the function definition. expeller_tile -> target_tile > "Your %s succeeded in expelling the %s." Can the actor fail? > + if (pcity || !is_capital(pcity)) { Translated to English: "If the city exists or the city isn't a capital." Will crash if the city doesn't exist. You need to handle the corner case where no city to deport to is found. _______________________________________________________ Reply to this item at: <http://gna.org/patch/?5306> _______________________________________________ Message sent via/by Gna! http://gna.org/ _______________________________________________ Freeciv-dev mailing list [email protected] https://mail.gna.org/listinfo/freeciv-dev
