URL:
<http://gna.org/bugs/?23772>
Summary: Dev save compat can corrupt 3.0 custom ruleset join
city orders
Project: Freeciv
Submitted by: sveinung
Submitted on: Sun 09 Aug 2015 02:48:57 PM UTC
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
Status: None
Assigned to: None
Originator Email:
Open/Closed: Open
Release: TRUNK
Discussion Lock: Any
Operating System: Any
Planned Release: 3.0.0
_______________________________________________________
Details:
Reported by Jacob Nevins <jtn> in comment #2 of patch #6187
sg_order_to_action() will convert any ORDER_BUILD_CITY that doesn't target a
tile with a domestic city to ORDER_PERFORM_ACTION + ACTION_FOUND_CITY. (It is
called before some foreign cities have been loaded)
This isn't a problem for pre 3.0 save games. Pre 3.0 save games ordering a
unit to join a foreign city doesn't exist. A unit couldn't join foreign cities
before 3.0.
It isn't a problem in any bundled rule set or in any rule set bundled by
Freeciv-web. All bundled 3.0 rulesets still requires that the city the unit
joins is domestic. The same is true for the Freeciv-web rulesets.
When dev-save-compat is enabled it becomes a problem for 3.0 save games from
custom rulesets that allows joining allied cities. An ORDER_BUILD_CITY
intended as a command to join an allied city will be interpreted as a command
to found a city at the tile of the allied city. If the allied city isn't
loaded yet the tile appears free. If the allied city is loaded it will be seen
as "not join" because the city is foreign. dev-save-compat is enabled by
default because 3.0 is a development version.
_______________________________________________________
Reply to this item at:
<http://gna.org/bugs/?23772>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Freeciv-dev mailing list
[email protected]
https://mail.gna.org/listinfo/freeciv-dev
