Follow-up Comment #53, patch #6104 (project freeciv):
- Why are you putting new UTYF -values to such early indices? You owuld need
less changes if you made them last ones before USER values. There's also a bit
of bad news for you in that patch #6424 also making changes there most likely
goes in before your patch, causing your patch then no longer to apply. You may
want to base your patch on top of patch #6424 already
- stdsounds.soundspec typo "e_unit_escpaed" should be "e_unit_escaped"
- You should use one of the iterating macros with "adjacent" in them instead
of circle_iterate (that's a completely different thing) That's probably the
bug you're seeing yourself.
- You should not disallow escaping to a tile because of allied tiles there
(you currently allow only own units)
- 'break' does not always work with the _iterate macros (as they may hide
multiple levels of loops) so you can't really count on getting to next round
in the loop after one - wrap checks for further potential escape tiles to "if
(!escaped) {"
- Mark message sent to player for translation
- Make the message with correct pluralization. You need to calculate the
number of units that have escaped and then use PL_() base on that
_______________________________________________________
Reply to this item at:
<http://gna.org/patch/?6104>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Freeciv-dev mailing list
[email protected]
https://mail.gna.org/listinfo/freeciv-dev
