On 15.06.2012 00:35, Michael T. Pope wrote: > On Thu, 14 Jun 2012 06:45:53 AM Michael Vehrs wrote: > >> Yesterday, I had the idea of moving the initial goods price ranges into >> the game options. This would enable the player to set the minimum and >> maximum value of the randomly generated initial price. The same could be >> done for the price spread. And unit prices might also be moved into game >> options. >> >> This change would implement the long-standing request that the hammer >> price be made configurable again. What do you think? >> > Generally, I like options, and IMHO with the tree-view in place we can afford > to have some more. However IIRC ATM the initial goods prices are in the > goods-type definition in the spec. That seems like a good place already. > Could > the game option get its default value/s from the goods-type definition? (Also > IIRC) the current variability is hard coded --- if so that should go into the > spec somewhere and a game option is a sensible place. > > Cheers, > Mike Pope >
I agree that the goods type definition is a reasonable place to put the options. For this reason, I propose to allow game options outside of option groups, giving us something like: <goods-type id="model.goods.silver" ...> <integer-option id="model.goods.silver.initialPrice.minimum" value="17" /> <integer-option id="model.goods.silver.initialPrice.maximum" value="20" /> <integer-option id="model.goods.silver.priceSpread" value="3" /> </goods-type> The alternative would be to generate game options from the goods types dynamically, which we might have to do anyway, for the sake of compatibility. Regards Michael ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Freecol-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/freecol-developers
