On 28.06.2012 15:08, Paolo Bizzarri wrote: > On Thu, Jun 28, 2012 at 11:46 AM, Michael T. Pope<[email protected]> wrote: > >> On Wed, 27 Jun 2012 05:00:44 PM Paolo Bizzarri wrote: >> >>> I am trying to stick to some sane work on FreeCol, instead of my usual >>> random refactoring patters - I am currently on the networking code, >>> some of my refactoring is sane, but I am already (re)starting to work >>> on the handle stuff ...... so I think it's better to ask you what are >>> the major bugs or refactoring you are waiting for GUI stuff. >>> >>> I know the first one - getResponse - but it is a BIG thing and it >>> requires lots of concentrated work. I think I will leave this for the >>> holidays period. >>> >> I will be highly relieved when that gets sorted out. Because the whole user >> interaction can get trapped in the getResponse loop, I am constantly trying >> to >> guess whether this or that broken behaviour is just another case of >> getResponse capture. >> > This one is not a light task, as I discovered. Basically replacing the > JPanel with a JOptionPane destroys all existing support for PLAF, and > requires to be reviewed heavily. >
That seems to be a rather sweeping generalization. As far as I can see, we'd only have to add a PLAF implementation for JOptionPane, which is not rocket science (more like black magic). Of course, various utility methods from FreeColPanel would have to be made available somehow, but that's just grunt work. > It can't be done in small steps, because we are going to change a > fundamental class deep in the hierarchy.... > > I think this is scheduled for August, when holidays will provide the > required energy and time. > > > >> Anyway to answer your question, I would (predictably) recommend you look at >> the bug list for inspiration. >> > Yep, tried but it's really not clear what is GUI stuff.. > > >> On my working notes for the open bugs, the >> biggest category is for UI issues, so its not hard to find possibilities. >> Here >> are my picks: >> >> - BR#1694733 Some dialogs should not be resizeable >> This is our oldest open bug, so it deserves some time. I believe it is >> currently assigned to Nick, but I doubt he would object if it was fixed. >> >> > Seen that, I am trying to figure out how to make JPanel not > resizable... apparently there are solutions.. > > >> - There are several bugs connected to handling of double-clicks (BR#2808496, >> BR#2880406, BR#3293020). >> >> > ok > > >> - BR#2930345, where the colony dialogs disappear behind the colony panel, >> which makes the game appear to hang. Very annoying to the unwary user. >> >> > ok > > > >> On more structural matters: >> >> - I recently re-enabled some tests for headless mode. For testing purposes, >> it would be nice if it actually worked. >> >> > Yes. I am also working to make GUI an interface, this would allow > testing client controllers in isolation. > > > >> - I there is a single file that could do with a clean up, my pick would be >> DefaultTransferHandler.java. DragListener is close behind. >> >> > What's wrong with this class? /me looks at it. > > Well, it has very long and convoluted if/else statements and depends on the implementation details of various panel and label classes, which does not look like a good idea. We could add interfaces for unit sources and sinks, as well as goods sources and sinks, for example, and make the relevant panels implement these interfaces. > Ciao > > PaoloB > > > >> Cheers, >> Mike Pope Regards Michael ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Freecol-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/freecol-developers
