On Thu, 28 Jun 2012 03:08:19 PM Paolo Bizzarri wrote: > > - I there is a single file that could do with a clean up, my pick would be > > DefaultTransferHandler.java. DragListener is close behind. > > What's wrong with this class? /me looks at it.
I expect it got that way over time, but it is written as if object oriented programming was never invented. If you ever have to hunt through it to work out why some object handling is failing you will see what I mean--- you have to work through the whole function to find the case you want, which might have been masked by a more general earlier test. IMHO wherever you see more than a three or so uses of `instanceof', trouble is brewing. Cheers, Mike Pope
signature.asc
Description: This is a digitally signed message part.
------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________ Freecol-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/freecol-developers
