> Gesendet: Montag, 30. März 2015 um 12:23 Uhr > Von: "Michael T. Pope" <mp...@computer.org> > An: freecol-developers@lists.sourceforge.net > Betreff: Re: [Freecol-developers] The size of dialogs > > On Sun, 29 Mar 2015 22:14:15 +0200 > win...@genial.ms wrote: > > as I slowly made some (of the many needed) changes to enable the game > > having scaling > > (see also BR#2726), I made a couple observations and would like to know > > what you > > think about them. > > > > I found I could very easily allow the map to be zoomed in some more (2-3 > > line change, > > if no graphical glitch appears). > > Having the tiles be double size should be nice, but should the steps > > inbetween stay > > at 25% of original size? Should I try enabling it? > > Would it still look nice or get blocky? > > The only way we will really find out is to try it and see. > Have you tried it out since I implemented this and is the visual quality good enough?
> > The game is very inconsistent with applying the scale factor (which is saved > > in ImageLibrary) when images are needed. > > I would think there are only 2 cases/scaling factors needed, anything on > > the map > > and anything else in the GUI. > > Do not forget the MiniMap. > Thanks, I'll think of it. I also found many places using the ImageLibrary in GUI interchangably with the one in GUI.colonyTileMapViewer, which I corrected yesterday. > > Both exist already and the one for the GUI is currently > > always 1, though there are also many images and fonts its not applied to > > atm, where I > > would like to add it. I would assume there is nothing which should never be > > scaled, > > or did I miss anything? > > How do the predefined images look? (e.g. meeting Aztecs etc) IIRC this > came up a while back when the EuropePanel had a graphical background. > I applied the scaling factor to many more images meanwhile and checked by temporarily having GUI create the ImageLibrary with a scaling factor of 2 and the opening all panels and subpanels I could get access to from the menus, which already lead to some improvements. Its difficult for me to check the dialogs which show up only on specific circumstances. Is there already any easier way to show them than playtesting for weeks? If not, some debug code may need to get added to show these on demand. > > Would it help to branch the code or only add more work? > > How you want to work is your call. All I can add there is that whenever I > have tried to do a big rework in a branch, I get annoyed with trying to > keep it in sync with important bug fixes happening in master. Then, when I > finally merge, there are surprises, usually bad ones. Hence my preference > for small cumulative changes in master, which then get better testing and > yet are still easy to back out. > Yes, I already try to avoid holding on to code privately to avoid merge conflicts. I think when it gets unavoidable I'll make a branch containing only the absolute minimum of code to activate the half-implemented feature and regularly rebase and force-push it, if that is an acceptable thing to do? > > For example: > > There are 5 or even more slightly different sizes for the unit images used, > > which > > I would think could be reduced to 3 or maybe even 2? > > Very likely. I encourage you to try it and see. > For now I got most scaling factors for images centralized in ImageLibrary and only took away single use sizes. But I hope the number can get reduced easier now, though still needs checking if the panels wont get glitched on each change. > Some dialogs/panels are just special/weird, so there is going to be a > point of diminishing returns here. However you are right that there are a > lot of unnecessarily different special cases. What specifically would you > like to unify? > The Indian advisor panel is showing most differences to other panels. The small version of the headerfont is only used in a few other panels and many dont use it. This could be made more consistent, though I'm unsure if it should be removed or used more on other panels for subheaders. Also its the only panel currently using a bold version of the normal font for subsubheaders, which could be used on other panels, too. And many panels could get a bit reformatted to look more consistent. > Cheers, > Mike Pope > Regards wintertime ------------------------------------------------------------------------------ Dive into the World of Parallel Programming The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/ _______________________________________________ Freecol-developers mailing list Freecol-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/freecol-developers
