On 1.7.2011 14:00, Alexander Bokovoy wrote:
Hi,
On 01.07.2011 14:54, Jan Cholasta wrote:
On 1.7.2011 11:44, Alexander Bokovoy wrote:
New version: forgot to import package_installed_name from ipautil.
Previous version can be ignored.
ipa-client-install should be usable on non-RH platforms (see
https://fedorahosted.org/freeipa/ticket/1374), so you shouldn't use
/bin/rpm, as that's platform-specific. Wouldn't just rephrasing the
warning message (as suggested in the ticket) be sufficient?
If you want to support non-rpm-based platforms, you'll need to do much
greater work than not depend on rpm. For example, /sbin/service and
chkconfig might not be there.
I'm not sure adding even more complexity is helpful, especially when
it's used just to print a warning message. But I'd like a second opinion
on this.
All this is abstracted now in ipautil.py and right thing for those
platforms would be to provide appropriate implementation of the ipautil.py.
Honza
--
Jan Cholasta
_______________________________________________
Freeipa-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/freeipa-devel
