Simo Sorce wrote:
On Fri, 2011-07-01 at 14:18 +0200, Jan Cholasta wrote:
On 1.7.2011 14:00, Alexander Bokovoy wrote:
Hi,
On 01.07.2011 14:54, Jan Cholasta wrote:
On 1.7.2011 11:44, Alexander Bokovoy wrote:
New version: forgot to import package_installed_name from ipautil.
Previous version can be ignored.
ipa-client-install should be usable on non-RH platforms (see
https://fedorahosted.org/freeipa/ticket/1374), so you shouldn't use
/bin/rpm, as that's platform-specific. Wouldn't just rephrasing the
warning message (as suggested in the ticket) be sufficient?
If you want to support non-rpm-based platforms, you'll need to do much
greater work than not depend on rpm. For example, /sbin/service and
chkconfig might not be there.
I'm not sure adding even more complexity is helpful, especially when
it's used just to print a warning message. But I'd like a second opinion
on this.
I think it is time we start renaming ipautil.py to ipautil-rh.py and do
ourselves, or invite someone to write ipautil-debian.py, then have code
that loads the right module at runtime.
Simo.
I believe that nss-pam-ldapd uses a different configuration file than
nss_ldap, I think I'd rather use the existence of that to determine what
is being used. Calling out to rpm seems heavy-weight.
rob
_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel
