On 07/24/2013 02:39 PM, Jan Cholasta wrote:
On 17.7.2013 14:45, Petr Viktorin wrote:
On 07/16/2013 05:25 PM, Petr Viktorin wrote:
This exposes tasks such as installation, uninstallation, clean-up should
be available as CLI commands so they're available for non-Python tests.
https://fedorahosted.org/freeipa/ticket/3721
It also allows tests to install IPA in a specific topology by setting
the `topology` attribute to 'star', 'line', 'tree', etc. (so far only
'star' or none was supported).
The first patches contain some refactoring/enhancements needed to make
this possible.
I found a bug in patch 0246 and a typo in 0249. This update fixes them.
Patch 245:
Since you use tar -J, I think it might make sense to add tar and xz to
freeipa-tests requires.
Thanks for the catch. That patch just moves the code around, it doesn't
introduce the dependencies.
Here's a separate patch to change the spec file.
Otherwise it looks good to me.
Thanks for the review
--
Petr³
From 4a932bb882caa96924f7b446a9e3149a353843a1 Mon Sep 17 00:00:00 2001
From: Petr Viktorin <[email protected]>
Date: Wed, 24 Jul 2013 14:43:43 +0200
Subject: [PATCH] Add tar and xz dependencies to the freeipa-tests package
The beakerLib plugin collects log files via compressed tarballs,
so these dependencies are needed
---
freeipa.spec.in | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/freeipa.spec.in b/freeipa.spec.in
index 52e90bf3db514d899f37a8c0e97684bac8366337..912eeaffbc238c35cd788ca70624c4bf13c11e5d 100644
--- a/freeipa.spec.in
+++ b/freeipa.spec.in
@@ -297,6 +297,8 @@ package.
Summary: IPA tests and test tools
Requires: %{name}-client = %{version}-%{release}
Requires: %{name}-python = %{version}-%{release}
+Requires: tar
+Requires: xz
Requires: python-nose
Requires: python-paste
Requires: python-coverage
@@ -827,6 +829,9 @@ fi
%endif # ! %{ONLY_CLIENT}
%changelog
+* Wed Jul 14 2013 Petr Viktorin <[email protected]> - 3.2.99-2
+- Add tar and xz dependencies to freeipa-tests
+
* Thu Jul 18 2013 Ana Krivokapic <[email protected]> - 3.2.99-8
- Bump minimum version of sssd to 1.10.90 for the 'ipa_server_mode' option.
--
1.8.3.1
_______________________________________________
Freeipa-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/freeipa-devel
