On 07/24/2013 03:46 PM, Petr Viktorin wrote:
On 07/24/2013 02:39 PM, Jan Cholasta wrote:
On 17.7.2013 14:45, Petr Viktorin wrote:
On 07/16/2013 05:25 PM, Petr Viktorin wrote:
This exposes tasks such as installation, uninstallation, clean-up
should
be available as CLI commands so they're available for non-Python tests.

https://fedorahosted.org/freeipa/ticket/3721

It also allows tests to install IPA in a specific topology by setting
the `topology` attribute to 'star', 'line', 'tree', etc. (so far only
'star' or none was supported).

The first patches contain some refactoring/enhancements needed to make
this possible.


I found a bug in patch 0246 and a typo in 0249. This update fixes them.


Patch 245:

Since you use tar -J, I think it might make sense to add tar and xz to
freeipa-tests requires.

Thanks for the catch. That patch just moves the code around, it doesn't
introduce the dependencies.
Here's a separate patch to change the spec file.

Rebased to current master.

Otherwise it looks good to me.

Thanks for the review



_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel



--
PetrĀ³
From 06b86d54db80584e08786cf93f1dc0c121f3a3d4 Mon Sep 17 00:00:00 2001
From: Petr Viktorin <pvikt...@redhat.com>
Date: Wed, 24 Jul 2013 14:43:43 +0200
Subject: [PATCH] Add tar and xz dependencies to the freeipa-tests package

The beakerLib plugin collects log files via compressed tarballs,
so these dependencies are needed
---
 freeipa.spec.in | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/freeipa.spec.in b/freeipa.spec.in
index 011b2809f365aa31cf5240f797177370a6d5a085..1b8122dfa7742c9277673036a96b657712e6ec76 100644
--- a/freeipa.spec.in
+++ b/freeipa.spec.in
@@ -297,6 +297,8 @@ package.
 Summary: IPA tests and test tools
 Requires: %{name}-client = %{version}-%{release}
 Requires: %{name}-python = %{version}-%{release}
+Requires: tar
+Requires: xz
 Requires: python-nose
 Requires: python-paste
 Requires: python-coverage
@@ -827,6 +829,9 @@ fi
 %endif  # ! %{ONLY_CLIENT}
 
 %changelog
+* Wed Jul 24 2013 Petr Viktorin <pvikt...@redhat.com> - 3.2.99-11
+- Add tar and xz dependencies to freeipa-tests
+
 * Wed Jul 24 2013 Tomas Babej <tba...@redhat.com> - 3.2.99-10
 - Move requirement for keyutils from freeipa-server to freeipa-python
 
-- 
1.8.3.1

_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Reply via email to