On Fri, 10 Oct 2014, Petr Vobornik wrote:
One more update for patch 0161, Petr noticed we need to call super
post_callback() too.
idoverrideuser_find callback causes internal error. I've attached new
version of the patch which fixes it. Basically it's this change:
diff --git a/ipalib/plugins/idviews.py b/ipalib/plugins/idviews.py
index 25b9bcf..bfa8675 100644
--- a/ipalib/plugins/idviews.py
+++ b/ipalib/plugins/idviews.py
@@ -831,11 +831,12 @@ class idoverrideuser_find(baseidoverride_find):
msg_summary = ngettext('%(count)d User ID override matched',
'%(count)d User ID overrides matched', 0)
- def post_callback(self, ldap, dn, entry_attrs, *keys, **options):
- dn = super(idoverrideuser_find, self).post_callback(ldap, dn,
- entry_attrs, *keys, **options)
- convert_sshpubkey_post(ldap, dn, entry_attrs)
- return dn
+ def post_callback(self, ldap, entries, truncated, *args, **options):
+ truncated = super(idoverrideuser_find, self).post_callback(
+ ldap, entries, truncated, *args, **options)
+ for entry in entries:
+ convert_sshpubkey_post(ldap, entry.dn, entry)
+ return truncated
If you are OK with it, then ACK for patches 160, 161-3, 162-1, 164 and 165.
I'm fine with your patch, copy/paste error, thanks for fixing it.
--
/ Alexander Bokovoy
_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel
