On 10/13/2014 12:14 PM, Petr Vobornik wrote: > On 10.10.2014 17:56, Alexander Bokovoy wrote: >> On Fri, 10 Oct 2014, Petr Vobornik wrote: >>>> One more update for patch 0161, Petr noticed we need to call super >>>> post_callback() too. >>>> >>> >>> idoverrideuser_find callback causes internal error. I've attached new >>> version of the patch which fixes it. Basically it's this change: >>> >>> >>> If you are OK with it, then ACK for patches 160, 161-3, 162-1, 164 and >>> 165. >> I'm fine with your patch, copy/paste error, thanks for fixing it. >> >> > > also ACK for 163. > > patch 159 still needs review. > > pushed to: > > master: > * 63be2ee9f0296e1366c77258929c7ce2dad53154 Support overridding user > shell in ID views > * ca42d3469a6f83376d33b08d7bb4b43c2e93d604 Allow user overrides to > specify SSH public keys > * b50524b10c82ed7931a2e84dbb029e8909aa8f3f Allow user overrides to > specify GID of the user > * 5ec23ccb5f1d21c6e6c56650c18d1b4296d59ac9 Allow override of gecos > field in ID views > * 6637449ad2d8885f6df43b4098f09289c7405129 Update API version for ID > views support > * 9fcc9a0163b7f485deae2fd000ae0ab554f9bb72 Require slapi-nis 0.54 or > later for ID views support > > ipa-4-1: > * 8a8d2e71f384bfa50477042cb8e82f14237caa7c Support overridding user > shell in ID views > * ad6d019b4784853c59fb2a38c5de149b02640841 Allow user overrides to > specify SSH public keys > * 240d93bd80a3fdc9f67640f74380eb748ffff43c Allow user overrides to > specify GID of the user > * aa0f5d35c5221e1d8ae270d354ff21d173b3194e Allow override of gecos > field in ID views > * 79c0b31c72a8d8db676f3a621371983e5d9cdf53 Update API version for ID > views support > * a4798c78372a66545d338b809afb45b5f9ada94d Require slapi-nis 0.54 or > later for ID views support
ACK for 159, works fine in my testing. Pushed to: master: bd98ab035665e9ed913b9c0efd11c7685f2034f3 ipa-4-1: 50f46fdeddc7f6d8529e2342614fa569b8d4d541 -- Tomas Babej Associate Software Engineer | Red Hat | Identity Management RHCE | Brno Site | IRC: tbabej | freeipa.org _______________________________________________ Freeipa-devel mailing list [email protected] https://www.redhat.com/mailman/listinfo/freeipa-devel
