On 11/27/2014 04:12 PM, Petr Spacek wrote: > On 27.11.2014 11:00, Martin Basti wrote: >> On 27/11/14 00:50, Gabe Alford wrote: >>> Hello, >>> >>> Wondering if I could get a review. Updated patch attached. >>> >>> Thanks, >>> Gabe >>> >>> On Tue, Nov 11, 2014 at 7:21 AM, Gabe Alford <redhatri...@gmail.com >>> <mailto:redhatri...@gmail.com>> wrote: >>> >>> Hello, >>> >>> Fix for https://fedorahosted.org/freeipa/ticket/4700 >>> >>> Thanks, >>> >>> Gabe >>> >>> >>> >> Hello, >> >> sorry for late response. >> >> We push this ticket to backlog, as it would be part of build system >> refactoring. >> The "app_PYTHON" statement is not used anymore in IPA, the better solution is >> remove it, instead of keeping dead code up-to-date. > > Just to clarify: > It can be pushed if it works, there is no need to postpone accepting patch if > the patch seems okay and doesn't break anything. > > Martin, please keep in mind that contributions are welcome at any time. > > Milestones in Trac reflect our view of priorities but it doesn't prevent us > from accepting correct patches from contributions at any time, no matter which > priority is stated in Trac (or even if there is no ticket for it ...).
This is not a problem of prioritization and the Trac tickets do not indeed prevent accepting contributions to current FreeIPA branches (well, of course, big refactoring would not fit stabilization release etc.). However, AFAIU, in this case Gabe tried to make an unused autotool option up to date, which as Martin correctly stated "the better solution is remove it, instead of keeping dead code up-to-date". So in this light, the patch does not break anything, but is not the best move forward either as it would promote redundant work in maintaining unused autotools variable. Martin _______________________________________________ Freeipa-devel mailing list Freeipaemail@example.com https://www.redhat.com/mailman/listinfo/freeipa-devel