This patch removes the app_PYTHON usage. Thanks,
Gabe On Thu, Nov 27, 2014 at 9:40 AM, Martin Kosek <[email protected]> wrote: > Exactly, this was the message from Martin :-) I did not test it myself, but > removing all app_PYTHON should be benign given we use Python setup.py > packaging. > > On 11/27/2014 04:27 PM, Gabe Alford wrote: > > Thanks guys. Sounds like it would be better to submit a patch that > removes > > app_PYTHON if it is considered dead code. > > > > Gabe > > > > On Thursday, November 27, 2014, Petr Spacek <[email protected]> wrote: > > > >> On 27.11.2014 11:00, Martin Basti wrote: > >>> On 27/11/14 00:50, Gabe Alford wrote: > >>>> Hello, > >>>> > >>>> Wondering if I could get a review. Updated patch attached. > >>>> > >>>> Thanks, > >>>> Gabe > >>>> > >>>> On Tue, Nov 11, 2014 at 7:21 AM, Gabe Alford <[email protected] > >> <javascript:;> > >>>> <mailto:[email protected] <javascript:;>>> wrote: > >>>> > >>>> Hello, > >>>> > >>>> Fix for https://fedorahosted.org/freeipa/ticket/4700 > >>>> > >>>> Thanks, > >>>> > >>>> Gabe > >>>> > >>>> > >>>> > >>> Hello, > >>> > >>> sorry for late response. > >>> > >>> We push this ticket to backlog, as it would be part of build system > >> refactoring. > >>> The "app_PYTHON" statement is not used anymore in IPA, the better > >> solution is > >>> remove it, instead of keeping dead code up-to-date. > >> > >> Just to clarify: > >> It can be pushed if it works, there is no need to postpone accepting > patch > >> if > >> the patch seems okay and doesn't break anything. > >> > >> Martin, please keep in mind that contributions are welcome at any time. > >> > >> Milestones in Trac reflect our view of priorities but it doesn't > prevent us > >> from accepting correct patches from contributions at any time, no matter > >> which > >> priority is stated in Trac (or even if there is no ticket for it ...). > >> > >> -- > >> Petr^2 Spacek > >> > >> _______________________________________________ > >> Freeipa-devel mailing list > >> [email protected] <javascript:;> > >> https://www.redhat.com/mailman/listinfo/freeipa-devel > >> > > > > > > > > _______________________________________________ > > Freeipa-devel mailing list > > [email protected] > > https://www.redhat.com/mailman/listinfo/freeipa-devel > > > >
From 239b31ca8564b560c34d90cc3b7e28df451055fb Mon Sep 17 00:00:00 2001 From: Gabe <[email protected]> Date: Sat, 29 Nov 2014 17:03:39 -0700 Subject: [PATCH] Remove usage of app_PYTHON in Makefiles https://fedorahosted.org/freeipa/ticket/4700 --- ipa-client/Makefile.am | 1 - ipa-client/configure.ac | 1 - ipa-client/ipaclient/Makefile.am | 17 ----------------- ipaserver/install/Makefile.am | 27 --------------------------- ipaserver/install/plugins/Makefile.am | 24 ------------------------ 5 files changed, 70 deletions(-) delete mode 100644 ipa-client/ipaclient/Makefile.am delete mode 100644 ipaserver/install/Makefile.am delete mode 100644 ipaserver/install/plugins/Makefile.am diff --git a/ipa-client/Makefile.am b/ipa-client/Makefile.am index b9c7020f3b687b3c0030ed5166625e6ef07e2fa4..467b814a4eb773771312c29aafd9f816771230d4 100644 --- a/ipa-client/Makefile.am +++ b/ipa-client/Makefile.am @@ -84,7 +84,6 @@ ipa_join_LDADD = \ SUBDIRS = \ ../asn1 \ - ipaclient \ ipa-install \ man \ $(NULL) diff --git a/ipa-client/configure.ac b/ipa-client/configure.ac index 78da8e6e413b8becbd4c75422abffb670050f446..7a3f3cb397526a8246e13b9c5a378041bddc18da 100644 --- a/ipa-client/configure.ac +++ b/ipa-client/configure.ac @@ -207,7 +207,6 @@ dnl --------------------------------------------------------------------------- AC_CONFIG_FILES([ Makefile ../asn1/Makefile - ipaclient/Makefile ipa-install/Makefile man/Makefile ]) diff --git a/ipa-client/ipaclient/Makefile.am b/ipa-client/ipaclient/Makefile.am deleted file mode 100644 index 01824b86584992fd84d4542da88395aa0e89de12..0000000000000000000000000000000000000000 --- a/ipa-client/ipaclient/Makefile.am +++ /dev/null @@ -1,17 +0,0 @@ -NULL = - -appdir = $(pythondir)/ipaclient -app_PYTHON = \ - __init__.py \ - ipachangeconf.py \ - ipadiscovery.py \ - ntpconf.py \ - ipa_certupdate.py \ - $(NULL) - -EXTRA_DIST = \ - $(NULL) - -MAINTAINERCLEANFILES = \ - *~ \ - Makefile.in diff --git a/ipaserver/install/Makefile.am b/ipaserver/install/Makefile.am deleted file mode 100644 index 9fcad4e77c93cf44ed5fcf3ff793233ba35482c1..0000000000000000000000000000000000000000 --- a/ipaserver/install/Makefile.am +++ /dev/null @@ -1,27 +0,0 @@ -NULL = - -appdir = $(pythondir)/ipaserver -app_PYTHON = \ - __init__.py \ - bindinstance.py \ - cainstance.py \ - dsinstance.py \ - ipaldap.py \ - krbinstance.py \ - httpinstance.py \ - ntpinstance.py \ - adtrustinstance.py \ - service.py \ - installutils.py \ - replication.py \ - certs.py \ - ldapupdate.py \ - certmonger.py \ - $(NULL) - -EXTRA_DIST = \ - $(NULL) - -MAINTAINERCLEANFILES = \ - *~ \ - Makefile.in diff --git a/ipaserver/install/plugins/Makefile.am b/ipaserver/install/plugins/Makefile.am deleted file mode 100644 index d651297ac141b0f05831e7fabbb9b561cdd239c7..0000000000000000000000000000000000000000 --- a/ipaserver/install/plugins/Makefile.am +++ /dev/null @@ -1,24 +0,0 @@ -NULL = - -appdir = $(pythondir)/ipaserver/install -app_PYTHON = \ - __init__.py \ - baseupdate.py \ - fix_replica_agreements.py \ - rename_managed.py \ - dns.py \ - updateclient.py \ - update_services.py \ - update_anonymous_aci.py \ - update_pacs.py \ - update_referint.py \ - ca_renewal_master.py \ - update_uniqueness.py \ - $(NULL) - -EXTRA_DIST = \ - $(NULL) - -MAINTAINERCLEANFILES = \ - *~ \ - Makefile.in -- 2.0.0
_______________________________________________ Freeipa-devel mailing list [email protected] https://www.redhat.com/mailman/listinfo/freeipa-devel
