Re: [Freeipa-devel] [PATCH 0041] permission-add does not prompt for ipapermright option in interactive mode

[Martin Basti]

On 29/01/15 17:10, Gabe Alford wrote:
Hello,
Fix for https://fedorahosted.org/freeipa/ticket/4872

Thanks,

Gabe


_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel
Thank you for your patch.

IMO, would be better to use flag, alwaysask for ipapermright, instead of 
creating new callback:

         StrEnum(
             'ipapermright*',
             cli_name='right',
             deprecated_cli_aliases={'permissions'},
             label=_('Granted rights'),
             doc=_('Rights to grant '
                   '(read, search, compare, write, add, delete, all)'),
             values=(u'read', u'search', u'compare',
                     u'write', u'add', u'delete', u'all'),
+            alwaysask=True,
         ),

This change requires to generate new API.txt

please run ./makeapi  and increment API version in VERSION file.

Thank you in advance :-)

Martin^2

--
Martin Basti

_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel