Good point. I personally was not aware of all that the API can do. Thanks
Martin^2! Updated patch attached.

On Tue, Feb 10, 2015 at 11:42 AM, Martin Basti <mba...@redhat.com> wrote:

>  On 29/01/15 17:10, Gabe Alford wrote:
>
>  Hello,
>
>  Fix for https://fedorahosted.org/freeipa/ticket/4872
>
>  Thanks,
>
> Gabe
>
>
> _______________________________________________
> Freeipa-devel mailing 
> listFreeipa-devel@redhat.comhttps://www.redhat.com/mailman/listinfo/freeipa-devel
>
>  Thank you for your patch.
>
> IMO, would be better to use flag, alwaysask for ipapermright, instead of
> creating new callback:
>
>          StrEnum(
>              'ipapermright*',
>              cli_name='right',
>              deprecated_cli_aliases={'permissions'},
>              label=_('Granted rights'),
>              doc=_('Rights to grant '
>                    '(read, search, compare, write, add, delete, all)'),
>              values=(u'read', u'search', u'compare',
>                      u'write', u'add', u'delete', u'all'),
> +            alwaysask=True,
>          ),
>
> This change requires to generate new API.txt
>
> please run ./makeapi  and increment API version in VERSION file.
>
> Thank you in advance :-)
>
> Martin^2
>
> --
> Martin Basti
>
>

Attachment: freeipa-rga-0041-2-permission-add-does-not-prompt-for-ipapermright-in-i.patch
Description: Binary data

_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Reply via email to