On 08/14/2015 06:57 AM, Abhijeet Kasurde wrote:
On 08/13/2015 07:08 PM, Martin Basti wrote:
On 08/10/2015 01:47 PM, Abhijeet Kasurde wrote:
Hi All,
This patch fixes bug - https://fedorahosted.org/freeipa/ticket/3406
Thanks,
Abhijeet Kasurde
Hello,
thank you for the patch
1)
- except ValueError:
+ except EOFError, ValueError:
Please use
except (EOFError, ValueError):
https://docs.python.org/2/tutorial/errors.html#handling-exceptions
OK, I will include this.
2)
I'm not sure if this code will work (I did not test it)
I expect when stdin is closed, this will result into infinite loop,
because raw_input will always return EOFError.
while True:
try:
ret = raw_input("%s: " % prompt)
if allow_empty or ret.strip():
return ret
except EOFError:
pass
Could you please elaborate more on, so that I can include fix in this
section of code?
If you receive EOF you cannot continue in while cycle because, it will
return EOF every iteration forever.
If EOF is received the while cycle must end, and appropriate action must
be take.
It depends on situation, if default value is present then default value
should be used, or in case if empty value is allowed, empty string
should be returned.
In case there is no default value and empty value is not allowed, then
an exception should be raised.
Martin^2
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
