On 04/21/2016 03:29 PM, Martin Babinsky wrote:
On 04/21/2016 03:25 PM, Martin Babinsky wrote:
On 04/21/2016 11:24 AM, Milan Kubík wrote:
On 04/05/2016 12:07 PM, Martin Babinsky wrote:
On 04/05/2016 10:24 AM, Milan Kubík wrote:
On 04/05/2016 10:17 AM, Milan Kubík wrote:
On 04/05/2016 09:31 AM, Martin Babinsky wrote:
On 04/01/2016 12:02 PM, Milan Kubík wrote:

Patches attached.



https://fedorahosted.org/freeipa/ticket/5733







Hi Milan,



I would be more happy if you could send a separate patch for the
context
manager fix, since the issue is orthogonal to the added test case
(even
if the test suite explodes without it).



Otherwise LGTM.






Done. Patch 0035 now applies to all branches, context manager fix
needs separate patch for ipa-4-2.

Updated commit message in patches 0036 to include the ticket.

Thanks, ACK.

Add freeipa-devel back to the loop & push request :)

--
Milan Kubik

Ah sorry I forgot how to mailing list.

ACK again for our push-bot (aka mbasti)


I see that the fix for the failing test was already pushed so you can remove the xfail mark from the test and it should be all green now.

Sorry for the confusion.


I haven't noticed, sorry. Updated patch attached.


--
Milan Kubik

From cd49ec790918c7b006afe9ee542ff055739b0b74 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Milan=20Kub=C3=ADk?= <mku...@redhat.com>
Date: Tue, 5 Apr 2016 10:04:03 +0200
Subject: [PATCH] ipatests: Add test case for requesting a certificate with
 full principal.

https://fedorahosted.org/freeipa/ticket/5733
---
 ipatests/test_xmlrpc/test_caacl_profile_enforcement.py | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/ipatests/test_xmlrpc/test_caacl_profile_enforcement.py b/ipatests/test_xmlrpc/test_caacl_profile_enforcement.py
index dca4151d614a4c2e2f5a09455426d117da4c1c80..11c040966003e2ea86149359c8aacb953e9fdd37 100644
--- a/ipatests/test_xmlrpc/test_caacl_profile_enforcement.py
+++ b/ipatests/test_xmlrpc/test_caacl_profile_enforcement.py
@@ -130,6 +130,13 @@ class TestCertSignMIME(XMLRPC_test):
             api.Command.cert_request(csr, principal=smime_user,
                                      profile_id=smime_profile.name)
 
+    def test_sign_smime_csr_full_principal(self, smime_profile, smime_user):
+        csr = generate_user_csr(smime_user)
+        smime_user_principal = '@'.join((smime_user, api.env.realm))
+        with change_principal(smime_user, SMIME_USER_PW):
+            api.Command.cert_request(csr, principal=smime_user_principal,
+                                     profile_id=smime_profile.name)
+
 
 @pytest.mark.tier1
 class TestSignWithDisabledACL(XMLRPC_test):
-- 
2.8.0

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to