On 04/21/2016 03:55 PM, Milan Kubík wrote:
On 04/21/2016 03:29 PM, Martin Babinsky wrote:
On 04/21/2016 03:25 PM, Martin Babinsky wrote:
On 04/21/2016 11:24 AM, Milan Kubík wrote:
On 04/05/2016 12:07 PM, Martin Babinsky wrote:
On 04/05/2016 10:24 AM, Milan Kubík wrote:
On 04/05/2016 10:17 AM, Milan Kubík wrote:
On 04/05/2016 09:31 AM, Martin Babinsky wrote:
On 04/01/2016 12:02 PM, Milan Kubík wrote:
Patches attached.
https://fedorahosted.org/freeipa/ticket/5733
Hi Milan,
I would be more happy if you could send a separate patch for the
context
manager fix, since the issue is orthogonal to the added test case
(even
if the test suite explodes without it).
Otherwise LGTM.
Done. Patch 0035 now applies to all branches, context manager fix
needs separate patch for ipa-4-2.
Updated commit message in patches 0036 to include the ticket.
Thanks, ACK.
Add freeipa-devel back to the loop & push request :)
--
Milan Kubik
Ah sorry I forgot how to mailing list.
ACK again for our push-bot (aka mbasti)
I see that the fix for the failing test was already pushed so you can
remove the xfail mark from the test and it should be all green now.
Sorry for the confusion.
I haven't noticed, sorry. Updated patch attached.
--
Milan Kubik
All is green, ACK.
I would recommend pushing patch 0036 first, then patch 0035 to avoid
false negative errors when bisecting.
--
Martin^3 Babinsky
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
