On 21.04.2016 16:30, Martin Babinsky wrote:
On 04/21/2016 03:55 PM, Milan Kubík wrote:
On 04/21/2016 03:29 PM, Martin Babinsky wrote:
On 04/21/2016 03:25 PM, Martin Babinsky wrote:
On 04/21/2016 11:24 AM, Milan Kubík wrote:
On 04/05/2016 12:07 PM, Martin Babinsky wrote:
On 04/05/2016 10:24 AM, Milan Kubík wrote:
On 04/05/2016 10:17 AM, Milan Kubík wrote:
On 04/05/2016 09:31 AM, Martin Babinsky wrote:
On 04/01/2016 12:02 PM, Milan Kubík wrote:

Patches attached.



https://fedorahosted.org/freeipa/ticket/5733







Hi Milan,



I would be more happy if you could send a separate patch for the
context
manager fix, since the issue is orthogonal to the added test case
(even
if the test suite explodes without it).



Otherwise LGTM.






Done. Patch 0035 now applies to all branches, context manager fix
needs separate patch for ipa-4-2.

Updated commit message in patches 0036 to include the ticket.

Thanks, ACK.

Add freeipa-devel back to the loop & push request :)

--
Milan Kubik

Ah sorry I forgot how to mailing list.

ACK again for our push-bot (aka mbasti)


I see that the fix for the failing test was already pushed so you can
remove the xfail mark from the test and it should be all green now.

Sorry for the confusion.


I haven't noticed, sorry. Updated patch attached.


--
Milan Kubik


All is green, ACK.

I would recommend pushing patch 0036 first, then patch 0035 to avoid false negative errors when bisecting.

Tests pushed to:

master:
* b0b9972213760dcf351cdd85dbfe2c38fc21b2e6 ipatests: fix for change_principal context manager * 0472300dffc1b77533a6bb7397d6a5fa11439303 ipatests: Add test case for requesting a certificate with full principal.
ipa-4-3:
* c4fa656b0e0850ddd6400caaa676eae4ec46da06 ipatests: fix for change_principal context manager * e183030067bae2df318324e9fcaafa8ea272f4b4 ipatests: Add test case for requesting a certificate with full principal.
ipa-4-2:
* eadd47eec6ceb38b001bc9bff14e2a5aa83eb2ab ipatests: fix for change_principal context manager * ffd670379b16940499c1ef86d676c05886cb1116 ipatests: Add test case for requesting a certificate with full principal.

--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to