On 03.05.2016 14:26, Lenka Doudova wrote:
On 05/03/2016 02:08 PM, Lenka Doudova wrote:
On 05/03/2016 12:15 PM, Martin Basti wrote:
On 03.05.2016 11:18, Lenka Doudova wrote:
On 05/03/2016 10:33 AM, Martin Basti wrote:
Hello I'm quite confused what is happening in that code, can you
explain it more to me? I see duplicated code there.
Sorry, that was just an unnecessary leftover. Fixed patch attached.
The code is expected to remove any certificates that were added to
the local host but not to try to remove the host itself.
Lenka
Martin^2
Looks better, please follow proper naming of patches according how
to format patch guide.
I propose following (Patch attached) changes. It looks weird to me
to return self object
Martin
Ok, fixed patch attached.
Thanks,
Lenka
And one more small change.
Lenka
ACK
Pushed to:
ipa-4-3: c8330a9b09c1999d2721f3fb2b2170b3c1568b22
master: 847c950408b3c00ce3a4625709cadcddf39af6a5
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
