On 24.06.2016 20:41, Lukas Slebodnik wrote:
On (24/06/16 21:09), Alexander Bokovoy wrote:
On Fri, 24 Jun 2016, Lukas Slebodnik wrote:
ah sorry, since 1.14.0 is not release yet we use 1.13.9x to track the
alpha and beta releases and still have incrementing version numbers. So,
it might be better to use '>= 1.13.90' in the spec file instead of
+1, At this point '>= 1.13.90' should be safe.
I vote for official release.
I cannot see a reason why this patch should be pushed immediately.
1.13.90 is just a sssd convention for alpha release and it can be confusing for
others whyt there isn't tarball for 1.13.90
It would allow git master to be built against sssd git master without
additional problems. It is consistency here that I'm after.

It allows it even now and without this patch.
I'm sorry I miss a logic here.
That's not true.

You wrote: "It would allow git master to be built"
against sssd git master"
One more time. This patch will not change that
because you can build freeipa git master
against "sssd git master" even now.

It's not my problem that freeipa requires git master of other project.
But it does not mean that you need to officialy requires
some weird version "1.13.90". It is really confusing.

it does not prevent you from running with the code that does not
have needed support. 1.13.4 has no extdom certificate request support
so you would need to make sure you are actually installing the correct
SSSD packages manually while changing the version to 1.13.90 would make
clear we demand a specific functionality.
Building freeipa and installing are two different things.
If you need to install freeipa git master then you need to use
extra copr anyway because:
A) you cannot install freeipa master in rawhide because there isn't
b) you cannot install freeipa master on fedora 24 due lots of missing
    dependencies (including libsss_nss_idmap-1.14.0)

If one would like to install freeipa git master rpms without copr
then he/she will not able to do it on fedora 24 without new libsss_nss_idmap
because dnf will not be able to find dependency

It is a very small thing, of
course, but helpful to those who have to deal with rebases/updates of
their distribution packages and have not been following freeipa-devel@
list in detail. At the very least the inability to find 1.13.90 in a
regular place would cause question being asked.

It's helpful but confusing. That's the reason why we should avoid using
1.13.90. I doubt that anyone will try to use alpha version of sssd or freeipa
on other distributions (debian, ubuntu) especially if they do not work reliably
on fedora. So there's no reason for a rush.


Pushed to master: a635135ba3caa6359c38f305d7982925ef3de50b

Version with dependency on 1.13.90 was pushed, we can increase it when SSSD 1.14.0 will be released

From 514cf22027cc8784256595d57b42bea23b1a2a77 Mon Sep 17 00:00:00 2001
From: Martin Basti <mba...@redhat.com>
Date: Wed, 22 Jun 2016 10:49:39 +0200
Subject: [PATCH] Bump SSSD version in requires

This is required by commit aa734da49440c5d12c0f8d4566505adaeef254e8 for
function sss_nss_getnamebycert()

 daemons/configure.ac | 2 +-
 freeipa.spec.in      | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/daemons/configure.ac b/daemons/configure.ac
index 2906def285a0f6ad9553fc07cbc59f7a7f7fd426..94d66d813728fe4e32f9e3c0eef920d8e2395d8f 100644
--- a/daemons/configure.ac
+++ b/daemons/configure.ac
@@ -253,7 +253,7 @@ dnl -- dirsrv is needed for the extdom unit tests --
 PKG_CHECK_MODULES([DIRSRV], [dirsrv  >= 1.3.0])
 dnl -- sss_idmap is needed by the extdom exop --
+PKG_CHECK_MODULES([SSSNSSIDMAP], [sss_nss_idmap >= 1.13.90])
 dnl ---------------------------------------------------------------------------
 dnl - Check for systemd unit directory
diff --git a/freeipa.spec.in b/freeipa.spec.in
index b04f819a9ceafe9506e0d5aaaaa073ae408fe898..71c24fd7c06a84ee1535516afa4fd89ebc0831ff 100644
--- a/freeipa.spec.in
+++ b/freeipa.spec.in
@@ -85,7 +85,7 @@ BuildRequires:  python-pyasn1 >= 0.0.9a
 BuildRequires:  python-qrcode-core >= 5.0.0
 BuildRequires:  python-dns >= 1.11.1
 BuildRequires:  libsss_idmap-devel
-BuildRequires:  libsss_nss_idmap-devel >= 1.12.2
+BuildRequires:  libsss_nss_idmap-devel >= 1.14.0
 BuildRequires:  java-headless
 BuildRequires:  rhino
 BuildRequires:  libverto-devel
@@ -327,7 +327,7 @@ Requires: pam_krb5
 Requires: curl
 Requires: libcurl >= 7.21.7-2
 Requires: xmlrpc-c >= 1.27.4
-Requires: sssd >= 1.13.3-5
+Requires: sssd >= 1.14.0
 Requires: python-sssdconfig
 Requires: certmonger >= 0.78
 Requires: nss-tools

Manage your subscription for the Freeipa-devel mailing list:
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to